Skip to content

fix: fix is_not_in for trie index #42716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jun 13, 2025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 13, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Jun 13, 2025
@mergify mergify bot added the kind/bug Issues or changes related a bug label Jun 13, 2025
@zhagnlu zhagnlu force-pushed the fix_is_not_null_trie branch from d495a9c to e8fe8b3 Compare June 13, 2025 04:50
@zhagnlu zhagnlu changed the title fix: fix is_not_null for trie index fix: fix is_not_in for trie index Jun 13, 2025
Copy link
Contributor

mergify bot commented Jun 13, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base (9af6c16) to head (e8fe8b3).
Report is 25 commits behind head on master.

❌ Your project check has failed because the head coverage (72.80%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #42716       +/-   ##
===========================================
- Coverage   81.85%   72.80%    -9.06%     
===========================================
  Files        1210      341      -869     
  Lines      188735    31914   -156821     
===========================================
- Hits       154493    23234   -131259     
+ Misses      27865     8680    -19185     
+ Partials     6377        0     -6377     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 72.80% <100.00%> (∅)
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/StringIndexMarisa.cpp 74.50% <100.00%> (ø)
internal/core/src/index/StringIndexMarisa.h 71.42% <ø> (ø)

... and 1549 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants