-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: [2.5] Make controller wait checker worker quit (#42704) #42726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.5
Are you sure you want to change the base?
Conversation
…ilvus-io#42704) Related to milvus-io#42702 This patch add wait logic for `CheckerController` and nil check for channel checker in case of panicking during server/testcase stop procedure Signed-off-by: Congqi Xia <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
/refresh-label |
[INFO] PR Label Summary by Refresh-Label
[SUCCESS] PR #42704 merged to master
Use /refresh-label to update related check and label manually |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #42726 +/- ##
===========================================
+ Coverage 70.70% 80.64% +9.94%
===========================================
Files 311 1431 +1120
Lines 30005 206513 +176508
===========================================
+ Hits 21214 166549 +145335
- Misses 8791 34093 +25302
- Partials 0 5871 +5871
🚀 New features to boost your workflow:
|
Cherry-pick from master
pr: #42704
Related to #42702
This patch add wait logic for
CheckerController
Nil check already exists due to code branching