Skip to content

fix: [2.5] Make controller wait checker worker quit (#42704) #42726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #42704
Related to #42702

This patch add wait logic for CheckerController
Nil check already exists due to code branching

…ilvus-io#42704)

Related to milvus-io#42702

This patch add wait logic for `CheckerController` and nil check for
channel checker in case of panicking during server/testcase stop
procedure

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 13, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 13, 2025
@sre-ci-robot sre-ci-robot added the do-not-merge/need-milestone generate by v2-label-manager label Jun 13, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #42704 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@congqixia congqixia added this to the 2.5.14 milestone Jun 13, 2025
@congqixia
Copy link
Contributor Author

/refresh-label

@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Jun 13, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Refresh-Label

[SUCCESS] PR #42704 merged to master

Use /refresh-label to update related check and label manually

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (01d408e) to head (ea6fd31).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #42726       +/-   ##
===========================================
+ Coverage   70.70%   80.64%    +9.94%     
===========================================
  Files         311     1431     +1120     
  Lines       30005   206513   +176508     
===========================================
+ Hits        21214   166549   +145335     
- Misses       8791    34093    +25302     
- Partials        0     5871     +5871     
Components Coverage Δ
Client 79.42% <ø> (∅)
Core 70.70% <ø> (ø)
Go 82.60% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/controller.go 96.52% <100.00%> (ø)

... and 1119 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants