introduce Event type and subsystem for event recorder #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
force-pushed
the
disk-logger
branch
2 times, most recently
from
b3d64a1 to
d38b04f
Compare
Praveenrajmani
force-pushed
the
disk-logger
branch
2 times, most recently
from
d3f47a2 to
4ab5b49
Compare
klauspost
reviewed
Apr 28, 2025
| Bucket string `json:"bucket,omitempty"` | ||
| Object string `json:"object,omitempty"` | ||
| VersionID string `json:"versionId,omitempty"` | ||
| Tags map[string]interface{} `json:"tags,omitempty"` |
There was a problem hiding this comment.
Aren't tags map[string]string?
| if resp.StatusCode != http.StatusOK { | ||
| return | ||
| } | ||
| dec := json.NewDecoder(resp.Body) |
There was a problem hiding this comment.
If this is to be a high throughput API, consider using msgp for the transfer.
You will need to get rid of the interface{} values. Let me know if you need assistance in setting that up.
(it should be pretty similar to this)
There was a problem hiding this comment.
these jwt libraries have claims defined in {}interface @klauspost let me try to simplify it
Praveenrajmani
force-pushed
the
disk-logger
branch
from
4ab5b49 to
7981314
Compare
|
Please rebase this with main branch now and move this code to v4 |
|
moving this PR to main |
|
|
|
ec is updated with v4 now, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.