Direct msgp to decode time.Time in UTC for all time values

[marktheunissen]

Currently the node your admin request hits will return UTC, but every other node will return .Local() timezone:

❯ mc admin heal vms --json | jq . |  grep last_update
              "last_update": "2025-05-07T12:17:19.098791885Z",
              "last_update": "2025-05-07T14:17:19.074143691+02:00",
              "last_update": "2025-05-07T14:17:18.015376327+02:00",
              "last_update": "2025-05-07T12:17:19.101336448Z",
              "last_update": "2025-05-07T14:17:19.078391397+02:00",
              "last_update": "2025-05-07T14:17:18.009332111+02:00",

After:

❯ mc admin heal vms --json | jq . |  grep last_update
              "last_update": "2025-05-07T12:55:17.304706378Z",
              "last_update": "2025-05-07T12:55:17.331246424Z",
              "last_update": "2025-05-07T12:55:17.333792588Z",
              "last_update": "2025-05-07T12:55:17.305889423Z",
              "last_update": "2025-05-07T12:55:17.332239139Z",
              "last_update": "2025-05-07T12:55:17.334615298Z",

[marktheunissen]

TODO: Remove me.

[klauspost]

👍🏼 tinylib/msgp#392 is the upstream change.

AIStor should probably have the same treatment.

[vadmeste]

@marktheunissen I do not fully understand the issue, does msgp strip the timezone information when marshalling it ?if yes, this means minio and mc should be compatible, right ? if that is the case, we need to release mc shortly after we release the server.

[klauspost]

@vadmeste The absolute time is the same. Msgpack timestamps (neither format) transmit timezone.

It is just a matter of which timezone is "attached" to the decoded time.Time, which will then produce different output when printed to text.

There is no difference to what is transmitted over the wire.

That is in contrast to JSON that preserves the timezone, therefore things serialized to JSON will contain the timezone set on the time.Time

[vadmeste]

Understood, thanks!