Skip to content

fix: prefix should use stringLike when new a bucketPolicy (2) #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2025

Conversation

mannreis
Copy link
Contributor

Addressing minio/minio#21244

Is there a reason why #2105 was closed? Does it not fix the issue or is there more to it?

This a new attempt to fix it!

@klauspost klauspost requested review from jiuker June 26, 2025 13:22
@jiuker
Copy link
Contributor

jiuker commented Jun 26, 2025

Stringlike used prefix to check, * will not have any difference. And mostly it's test case and some other places load this one as StringEqual, if I remember correctly.

@jiuker
Copy link
Contributor

jiuker commented Jun 26, 2025

Welcome to fix them

@mannreis
Copy link
Contributor Author

mannreis commented Jun 27, 2025

After further checking I think we need the wildcard appended to the prefix other wise it will behave as an exact match and there fore give permission denied. I found a similar example in the docs: https://min.io/docs/minio/linux/administration/identity-access-management/policy-based-access-control.html#minio-policy-variables-internal

Other wise removing the last two commits would address you suggestion.Thanks @jiuker

@harshavardhana harshavardhana merged commit 68615a3 into minio:master Jun 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants