-
-
Notifications
You must be signed in to change notification settings - Fork 44
show_category_heading: true and group_by_category: true does not work #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Proposed fix: pedrolabonia@0772ccc |
The point of the Let say Now if I think we need a more powerful function on the handler's side, to do this filtering for us based on the |
Hmm.. I get it. So that function would be in the |
Well I wanted to see how it could be done and I ended up implementing the change 😅 |
Also, can you confirm that the original issue was that in some cases the category headings were not rendered? It isn't clear in the description. |
In my case, I could never get them to render the category headings at all, and could never group the children by category. My object tree consisted of basically methods, properties and attributes with a parent class. No nesting or things like that. |
OK I've merged the PR. We'll need to wait for a new release of mkdocstrings before releasing one for the handler. That should'nt take too long. |
Describe the bug
Using
show_category_heading: true
andgroup_by_category: true
does not work.To Reproduce
Enable these settings
Expected behavior
Expected to have TOC separate them
Fix
The bug seems to happen here
python/src/mkdocstrings_handlers/python/templates/material/_base/children.html
Line 16 in d5ea1c5
Removing
any()
results in the expected behavior.Since we're calling
.values()
, if there's no values it already returnsFalse
.The text was updated successfully, but these errors were encountered: