Skip to content

Max repos list limited to 100 on index #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santiagax99 opened this issue Apr 22, 2016 · 3 comments
Closed

Max repos list limited to 100 on index #36

santiagax99 opened this issue Apr 22, 2016 · 3 comments

Comments

@santiagax99
Copy link

As i can see in RepositoryController.groovy restService.get('_catalog') is used to fill-up repos list, but by default /v2/_catalog from registry returns only 100 records. If there is more than 100 repos in registry we will see only first 100.

Is it possible to add variable or something else to have ability to fetch full list ?
From apiit can be done by passing ?n= to request, like http://localhost/v2/_catalog?n=1000

@mkuchin
Copy link
Owner

mkuchin commented Apr 22, 2016

Thanks for report, it seems it is better to check Link header and implement pagination:

For registries with a large number of repositories, this response may be quite large. If such a response is expected, one should use pagination. A registry may also limit the amount of responses returned even if pagination was not explicitly requested. In this case the Link header will be returned along with the results, and subsequent results can be obtained by following the link as if pagination had been initially requested.

For details of the Link header, please see the Pagination section.

mkuchin added a commit that referenced this issue Apr 26, 2016
@mkuchin
Copy link
Owner

mkuchin commented Apr 26, 2016

Pagination has been implemented in latest version on docker hub.

@santiagax99
Copy link
Author

Looks good! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants