-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add support to log customized tags to runs created by autolog #9114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…9064 Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
Documentation preview for 6ed7c2e will be available here when this CircleCI job completes successfully. More info
|
…to fix test failures Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
Hi @serena-ruan , could you help review the PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thinkall Overall looks great! Left a few comments :)
I think it could be more clear that we split tags test.
Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
Thank you Serana, I've split all the tests for extra_tags. Warning messages and built-in tags checking have been included as well. |
Signed-off-by: Li Jiang <[email protected]>
Signed-off-by: Li Jiang <[email protected]>
LGTM! @harupy You wanna take a look? 😃 |
Thank you @serena-ruan, and hi, @harupy ! Just a gentle reminder to take a look :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#9114) Signed-off-by: Li Jiang <[email protected]>
…#9114) Signed-off-by: Li Jiang <[email protected]> Signed-off-by: santiagxf <[email protected]>
…#9114) Signed-off-by: Li Jiang <[email protected]> Signed-off-by: Clark Hollar <[email protected]>
Related Issues/PRs
Resolve #9064
What changes are proposed in this pull request?
Added a parameter
extra_tags
to allautolog
functions, and passed it tosafe_patch
function inmlflow.utils.autologging_utils.safety.py
.With this
extra_tags
, users can log customized tags to runs created by autolog.How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
Users can set the parameter
extra_tags
inmlflow.autolog(extra_tags={"test_tag": "autolog"})
and all the other specific autolog functions such asmlflow.sklearn.autolog(extra_tags={"test_tag": "sklearn_autolog"})
to log theextra_tags
into runs created by autolog.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes