fix: set generate-authors
shell command built from environment values
#2471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongosh/scripts/generate-authors.ts
Line 10 in af7658f
mongosh/scripts/generate-authors.ts
Lines 17 to 18 in af7658f
Fix the issue should avoid dynamically constructing the shell command as a single string. Instead, we can use
execFileSync
, which allows us to pass the command and its arguments separately. This approach ensures that the arguments are not interpreted by the shell, mitigating the risk of command injection.Specifically:
execSync
withexecFileSync
in thegetAuthorsGitLog
function.git
command and its arguments as separate parameters toexecFileSync
.packagePath
is passed as an argument, rather than interpolated into the command string.