LG-4634: Ensure canvas is sized to container with correct pixel ratio #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb2709e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +105 B (+0.01%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
stephl3
approved these changes
Jan 15, 2025
…charts-line-blurriness
…charts-line-blurriness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This Doesn't
Actually fix blurriness, at least on the large monitor I'm viewing it on. It appears there's an ongoing issue about charts appearing blurry on canvas in echarts. I also see that in the echarts examples, if I set the
lineStyleof a series to a width of 1, I see the same level of "not perfectly smooth" as I see in our chart.This Does
Ensures that the the canvas is being sized correctly to the container and the correct pixel ratio is being used. There was a report of line blurriness occurring intermittently when users would return to their chart. I have yet to see this or be able to reproduce this. By making this change we're hopefully doing everything we can to ensure optimal rendering.
🎟 Jira ticket: LG-4634
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components