Proto install-global not working on windows?

[rotu]

What version?

0.23.1

Which command?

proto install-global

What happened?

Installing a global dependency on Windows doesn't seem to work.

proto install-global python pdm

Error: plugin::failed

  × Call failed
  │
  │ Caused by:
  │     0: error while executing at wasm backtrace:
  │            0: 0xb3db - <unknown>!<wasm function 160>
  │            1: 0x6aefc - <unknown>!<wasm function 912>
  │     1: program not found

I get a similar issue with proto install-global node rimraf.

Any logs?

python-debug.log
node-debug.log

Operating system?

Windows

Architecture?

x64

[rotu]

The input has context.tool_dir.path="/proto/tools/python/latest" which is not a directory. Even if the pinned global version is 3.11.6, the path still shows "latest". This may or may not be a red herring 🕵️

[TRACE 13:56.192] warpgate::plugin:install_global Calling plugin function install_global plugin="python" input={"context":{"tool_dir":{"path":"/proto/tools/python/latest","virtual_prefix":"/proto","real_prefix":"C:\Users\dan\.proto"},"version":"latest"},"dependency":"pdm","globals_dir":{"path":"/userhome/.local/bin","virtual_prefix":"/userhome","real_prefix":"C:\Users\dan"}}

[milesj]

@rotu Both of those fail with "program not found". Can you verify that PATH is correct?

For python, it would be using the pip shim: https://github.com/moonrepo/python-plugin/blob/master/src/proto.rs#L176
And node the npm shim: https://github.com/moonrepo/node-plugin/blob/master/crates/common/src/commands.rs#L6

I just tested proto install-global node rimraf myself and it worked. So maybe a Windows env var issue?

[rotu]

My path starts with C:\Users\dan\.proto\shims;C:\Users\dan\.proto\bin;. If I add a file called pip.exe (either to my shims folder or anywhere later in my path) then it tries to run that instead of returning "program not found".

I don't know how you expect this code to work - it calls exec_command which expects an executable, so I'm not sure how the .cmd or .ps1 shims could get invoked at all!

[milesj]

Does rust not use PATHEXT?!?! 😣

Let me dig deeper.

Edit: Omg it doesn't: https://github.com/rust-lang/rust/blob/master/library/std/src/sys/windows/process.rs#L417 And some context: rust-lang/rust#37381

Let me patch this then.

[rotu]

Re: #298

Can't we just skip the middleman and have proto install-global call commands::run::run itself? It seems a wee bit silly to open a shell, which opens the python(|.cmd|.ps1) shim, which wraps a second invocation of proto, which calls run().

[milesj]

proto doesn't know what processes/commands are going to be ran, so no, it cannot use run itself.

It was built this way so that installing/uninstalling a global can be more than just a child process in the wasm code. If they want, they can run fs operations as well, or modify env vars, etc.

[milesj]

can you try 0.23.2

[rotu]

proto doesn't know what processes/commands are going to be ran, so no, it cannot use run itself.

It was built this way so that installing/uninstalling a global can be more than just a child process in the wasm code. If they want, they can run fs operations as well, or modify env vars, etc.

Gotcha. I can see that the top-level code can't do this. But the call to exec_command is in python-plugin, which knows exactly how to invoke pip since it created the shim in the first place!

can you try 0.23.2

Roger! It installs something but the paths seem all incorrect:

proto install-global python pdm

...
Installing collected packages: pdm
━━━━━━ Installing pdm for Python
WARNING: The script pdm.exe is installed in 'C:\Users\dan\AppData\Roaming\Python\Python312\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed pdm-2.10.3
WARNING: There was an error checking the latest version of pip.
[ INFO 2023-11-20 16:45:43] proto::commands::install_global:install_global Installed pdm to ~/.local/bin!

proto list-global python

Error: × Main thread panicked.
├─▶ at crates\cli\src\commands\list_global.rs:54:54
╰─▶ called Result::unwrap() on an Err value: Os { code: 3, kind: NotFound, message: "The system cannot find the path specified." }
help: set the RUST_BACKTRACE=1 environment variable to display a backtrace.

proto install-global node rimraf

...
━━━ Installing rimraf for Node.js
added 41 packages in 1s
[ INFO 2023-11-20 16:51:14] proto::commands::install_global:install_global Installed rimraf to ~.proto/tools/node/globals/bin!

But the directory ~\.proto/tools/node/globals/bin doesn't exist. The files rimraf, rimraf.cmd, rimraf.ps1 are all in ~\.proto/tools/node/globals/.

proto list-global node

No global packages installed

[rotu]

BTW, great job on proto tool info python and proto tool info! These make it so much easier to get oriented!

[milesj]

The problem is that we only account for unix paths in the python plugin. Need to add C:\Users\dan\AppData\Roaming\Python\Python312\Scripts also (windows is annoying lol).

But the directory ~.proto/tools/node/globals/bin doesn't exist. The files rimraf, rimraf.cmd, rimraf.ps1 are all in ~.proto/tools/node/globals/.

Looks like another case of windows doing things differently -_-