Fix failing sharded_checkpoint tests that fail when pytorch 1.13 is not installed #1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eracah
changed the title
bandish-shah
requested changes
Feb 22, 2023
bandish-shah
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip all the tests in
test_sharded_checkpoint.pyIF pytorch 1.13 is not installed. This is because these tests use FSDP and if Composer uses FSDP and pytorch 1.13 is not installed, the process will fail.These failing tests do not mean anything will break for user, it just means the tests fail when they shouldn't
TLDR: add a pytest.skip call (conditional on pytorch 1.13 is not being installed) to all tests in
test_sharded_checkpoint.py