Skip to content

Update Docker images to fix resolve vulnerability scan issues #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 1, 2023

Conversation

bandish-shah
Copy link
Contributor

@bandish-shah bandish-shah commented Feb 26, 2023

What does this PR do?

This PR fixes the open high severity issue with OpenSSL and other medium/low vulnerability issues that have identified fixes.

This PR fixes critical/high severity issues with the following packages:

  • certifi
  • ipython
  • nodejs
  • openssl
  • pillow
  • urllib3

The following SW packages are removed. Users will need to install these manually or in their own images staged from MosaicML's public images at their own discretion:

  • vim

Open Issues

Docker Hub Scan False Positives

Testing

Vulnerability issues with Docker images are identified by first using the docker scan command locally, which uses Snyk to scan and then generating staged images and looking at the results of scanned images on the Docker Hub mosaicml/ci-staging private repository.

What issue(s) does this change relate to?

CO-1844

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@bandish-shah bandish-shah marked this pull request as ready for review February 27, 2023 02:28
@bandish-shah bandish-shah requested a review from a team as a code owner February 27, 2023 02:28
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a duplicate apt package upgrade -- should there only be one?

Should there be a GHA for recurring scanning?

@bandish-shah
Copy link
Contributor Author

Yea I had put two upgrades bc we install apt packages in the pytorch and pytorch_vision targets. I guess the one in pytorch_vision isn't necessary bc any new packages we're installing there are probably using latest. The upgrade is really addressing pre-installed packages in the staged image, I'll remove that.

No there isn't an accompanying GHA, we'll enable Docker Image scanning in Docker Hub for when the images are pushed.

@mvpatel2000 mvpatel2000 self-requested a review February 27, 2023 19:35
@bandish-shah bandish-shah merged commit b0365c8 into dev Mar 1, 2023
@bandish-shah bandish-shah deleted the bandish/fix_docker_scan branch March 1, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants