-
Notifications
You must be signed in to change notification settings - Fork 444
Update Docker images to fix resolve vulnerability scan issues #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a duplicate apt package upgrade -- should there only be one?
Should there be a GHA for recurring scanning?
Yea I had put two upgrades bc we install apt packages in the pytorch and pytorch_vision targets. I guess the one in pytorch_vision isn't necessary bc any new packages we're installing there are probably using latest. The upgrade is really addressing pre-installed packages in the staged image, I'll remove that. No there isn't an accompanying GHA, we'll enable Docker Image scanning in Docker Hub for when the images are pushed. |
…r into bandish/fix_docker_scan
…r into bandish/fix_docker_scan
What does this PR do?
This PR fixes the open high severity issue with OpenSSL and other medium/low vulnerability issues that have identified fixes.
This PR fixes critical/high severity issues with the following packages:
certifi
ipython
nodejs
openssl
pillow
urllib3
The following SW packages are removed. Users will need to install these manually or in their own images staged from MosaicML's public images at their own discretion:
vim
Open Issues
cryptography
can't be upgraded to 39.0.1, OCI requires <39mpmath
has not had a release in >2 years, seems to be in maintenance mode. This package is required byonnx-runtime
->sympy
->mpmath
Docker Hub Scan False Positives
certifi
package is updated to 2022.12.7, scanner is looking for 2022.12.07opencv-python
, we are on 4.5.5.64, other resources claim this vulnerability was fixed in >4.2.0.32opencv-python
, we are on 4.5.5.64, other resources claim this vulnerability was fixed in >4.1.1.26Testing
Vulnerability issues with Docker images are identified by first using the
docker scan
command locally, which uses Snyk to scan and then generating staged images and looking at the results of scanned images on the Docker Hubmosaicml/ci-staging
private repository.What issue(s) does this change relate to?
CO-1844
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)