Make it possible to define the root temporary directory for composer #3784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing if /local_disk0 exists, and if yes, using it for temp dir.
dakinggg
reviewed
Mar 19, 2025
| @@ -274,7 +274,13 @@ def __init__( | |||
|
|
|||
| is_remote_folder = backend != '' | |||
| if is_remote_folder: # If uploading to a remote path, use a temporary directory to save local checkpoints. | |||
| local_folder = os.path.join(tempfile.mkdtemp(), local_folder) | |||
| root_temp_folder = None | |||
There was a problem hiding this comment.
I believe this is already how mkdtemp works? https://docs.python.org/3/library/tempfile.html#tempfile.mkdtemp. The first place it should look to decide the tmpdir folder is whatever is specified by the TMPDIR env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to define the root temporary directory for composer
What does this PR do?
Checkpoints can become very large, and sometimes the temporary file system doesn't have enough disk space to accommodate them. This PR introduces the ability to use the TMPDIR environment variable to specify the root temporary directory. Additionally, if TMPDIR is not set and the /local_disk0 directory exists, the system will default to using /local_disk0/temp as the temporary directory.
Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)