Skip to content

Show the op dispatched by constructPath in the debugger #19961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolo-ribaudo
Copy link
Contributor

Show the op dispatched by constructPath in the debugger

The constructPath op receives as arguments not only the information to construct the path, but also the op to apply the path to (such as "fill", or "stroke").

This commit updates the Stepper tool in the debugger to decode that op, showing its name rather than just its numeric ID.

I was picking up #19043 again, and I think the internal representation of constructPath changed since when I first started working on it, making it more difficult to see what is going on in the debugger.

Before (and you would have to know that 22 means "fill"):
image

After:
image

The `constructPath` op receives as arguments not only the
information to construct the path, but also the op to apply
the path to (such as "fill", or "stroke").

This commit updates the Stepper tool in the debugger to decode
that op, showing its name rather than just its numeric ID.
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a14e570265d5204/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a14e570265d5204/output.txt

Total script time: 0.94 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@Snuffleupagus Snuffleupagus merged commit a8e05d8 into mozilla:master May 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants