Skip to content

Clean up logging #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Clean up logging #2335

merged 4 commits into from
Feb 18, 2025

Conversation

samuel-jimenez
Copy link
Contributor

Improve logging as discussed in point 1 of #2332.

Splits out heartbeats and raw HTTP as sccache_heartbeat and sccache_http, respectively.

@sylvestre
Copy link
Collaborator

please run rustfmt :)

@sylvestre sylvestre merged commit c719e5a into mozilla:main Feb 18, 2025
59 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0cc0c62) to head (daca8cf).
Report is 144 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2335       +/-   ##
==========================================
- Coverage   30.91%       0   -30.92%     
==========================================
  Files          53       0       -53     
  Lines       20112       0    -20112     
  Branches     9755       0     -9755     
==========================================
- Hits         6217       0     -6217     
+ Misses       7922       0     -7922     
+ Partials     5973       0     -5973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel-jimenez samuel-jimenez deleted the work/logging branch February 24, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants