misc.lua: add this script #16129
Open
misc.lua: add this script #16129
+116
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: Windows |
kasper93
reviewed
Mar 26, 2025
guidocella
force-pushed
the
utils
branch
3 times, most recently
from
b465f69 to
3629e3c
Compare
kasper93
reviewed
Mar 31, 2025
kasper93
reviewed
Apr 2, 2025
options/options.c
Outdated
| @@ -556,6 +556,7 @@ static const m_option_t mp_opts[] = { | |||
| {"load-select", OPT_BOOL(lua_load_select), .flags = UPDATE_BUILTIN_SCRIPTS}, | |||
| {"load-positioning", OPT_BOOL(lua_load_positioning), .flags = UPDATE_BUILTIN_SCRIPTS}, | |||
| {"load-commands", OPT_BOOL(lua_load_commands), .flags = UPDATE_BUILTIN_SCRIPTS}, | |||
| {"load-utils", OPT_BOOL(lua_load_utils), .flags = UPDATE_BUILTIN_SCRIPTS}, | |||
There was a problem hiding this comment.
Could we convert this to load option to string list? Not related to this PR, just an idea I got rn.
There was a problem hiding this comment.
I don't have a strong preference either way
kasper93
reviewed
Apr 2, 2025
player/lua/utils.lua
Outdated
| return | ||
| end | ||
|
|
||
| file_handle:write(initial_contents .. "\n") |
There was a problem hiding this comment.
do you need \n here, initial content seems to already have new line.
There was a problem hiding this comment.
Yeah it's not needed after I added newlines in the initial contents
guidocella
force-pushed
the
utils
branch
2 times, most recently
from
cb6fe78 to
e148a55
Compare
|
misc.lua, instead of utils.lua? It's more like miscellaneous functions than utils to be used by other scripts. |
|
This might be a name to be easily misunderstood. I thought it was related to the |
Add a script with script bindings to edit mpv.conf and input.conf, and add them to the menu. These are useful as shortcuts, but the main motivation is that new users often ask why they can't find mpv.conf and input.conf, so this creates them if they don't exist, also including links to the documentation. Other future script bindings that don't fit anywhere else can also be added to misc.lua.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script with script bindings to edit mpv.conf and input.conf, and add them to the menu. These are useful as shortcuts, but the main motivation is that new users often ask why they can't find mpv.conf and input.conf, so this creates them if they don't exist, also including links to the documentation.
Other future script bindings that don't fit anywhere else can also be added to utils.lua.