-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix broken build for python-zipp #10341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks I think that packages generally have |
I used AWS to provide an ARM64 runner for the CI, and turned it loose on all of your PRs merged together into one branch. https://github.com/msys2-arm/MINGW-packages/runs/4542133096?check_suite_focus=true. That's how I found that more-itertools seems to still be missing. |
Thanks for checking! In contrast to my other PRs, I didn't test this one on arm64 yet as its main purpose is to fix the broken build on x64 to start with. Just enabled
|
@lazka or someone want to weigh in on the name? I feel it should be python-jaraco-itertools Also:
|
all current jaraco submodules uses jaraco.* on our repo.. same as pypi.. but i prefer using - or _ |
IMO, follow archlinux naming scheme https://archlinux.org/packages/?sort=&q=jaraco&maintainer=&flagged= |
ok, didn't see the precedent. |
yeah, if unclear go with Arch. Makes matching up packages with Arch easier. |
Co-authored-by: jeremyd2019 <[email protected]>
Currently, building
python-zipp
fails with:The test dependencies in
setup.cfg
have changed between versions 2.0.0 and 2.2.1 (MINGW-packages is at 3.1.0 currently)... became
This PR adds the new dependencies. Please advise whether I added the new packages the right way - the build works and
python-zipp
tests are passing, but you might have some feedback on how thePKGBUILD
files are set up (I copied them from another existing Python package)