Skip to content

Fix broken build for python-zipp #10341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Dec 15, 2021

Currently, building python-zipp fails with:

Dennis@DESKTOP-0RP8NC0 MSYS /usr/src/MINGW-packages/mingw-w64-python-zipp
$ MINGW_ARCH=clang64 makepkg-mingw -sLf --skippgpcheck
==>  MINGW_ARCH: clang64
  -> Building clang64...
==> Making package: mingw-w64-python-zipp 3.1.0-2 (Wed Dec 15 22:17:29 2021)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Installing missing dependencies...
error: target not found: mingw-w64-clang-x86_64-python-unittest2
==> ERROR: 'pacman' failed to install missing dependencies.
==> Missing dependencies:
  -> mingw-w64-clang-x86_64-python-unittest2
==> ERROR: Could not resolve all dependencies.

The test dependencies in setup.cfg have changed between versions 2.0.0 and 2.2.1 (MINGW-packages is at 3.1.0 currently)

pathlib2
contextlib2
unittest2

... became

jaraco.itertools
func-timeout

This PR adds the new dependencies. Please advise whether I added the new packages the right way - the build works and python-zipp tests are passing, but you might have some feedback on how the PKGBUILD files are set up (I copied them from another existing Python package)

@jeremyd2019
Copy link
Member

Thanks

I think that packages generally have . changed to - in their names here, but maybe somebody who does more python packaging has an opinion.

@jeremyd2019
Copy link
Member

I used AWS to provide an ARM64 runner for the CI, and turned it loose on all of your PRs merged together into one branch. https://github.com/msys2-arm/MINGW-packages/runs/4542133096?check_suite_focus=true. That's how I found that more-itertools seems to still be missing.

@dennisameling
Copy link
Contributor Author

Thanks for checking! In contrast to my other PRs, I didn't test this one on arm64 yet as its main purpose is to fix the broken build on x64 to start with. Just enabled more-itertools for clangarm64 in 41ecd4b and that indeed allowed me to build python-zipp for clangarm64 as well 🎉

==> Tidying install...
  -> Removing libtool files...
  -> Purging unwanted files...
  -> Stripping unneeded symbols from binaries and libraries...
  -> Compressing man and info pages...
==> Checking for packaging issues...
==> Creating package "mingw-w64-clang-aarch64-python-zipp"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Finished making: mingw-w64-python-zipp 3.1.0-2 (Thu Dec 16 09:46:43 2021)

@jeremyd2019
Copy link
Member

I think that packages generally have . changed to - in their names here, but maybe somebody who does more python packaging has an opinion.

@lazka or someone want to weigh in on the name? I feel it should be python-jaraco-itertools

Also:

	message: mingw-w64-python-func-timeout: missing description suffix ‘(mingw-w64)’
	message: mingw-w64-python-inflect: missing description suffix ‘(mingw-w64)’
	message: mingw-w64-python-jaraco.itertools: missing description suffix ‘(mingw-w64)’

@raedrizqie
Copy link
Contributor

all current jaraco submodules uses jaraco.* on our repo.. same as pypi.. but i prefer using - or _

@Biswa96
Copy link
Member

Biswa96 commented Dec 17, 2021

IMO, follow archlinux naming scheme https://archlinux.org/packages/?sort=&q=jaraco&maintainer=&flagged=

@jeremyd2019
Copy link
Member

ok, didn't see the precedent.

@lazka
Copy link
Member

lazka commented Dec 17, 2021

yeah, if unclear go with Arch. Makes matching up packages with Arch easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants