Skip to content

fix(ui): not all models have an Icon #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix(ui): not all models have an Icon #4913

merged 1 commit into from
Feb 27, 2025

Conversation

mudler
Copy link
Owner

@mudler mudler commented Feb 27, 2025

Description

This pull request includes several changes to the core/http/views/chat.html file to improve the handling of the $galleryConfig.Icon variable. The changes ensure that the icon is only rendered if it exists, preventing potential errors.

The most important changes include:

  • Improved icon rendering:
    • Wrapped the icon image tags with conditionals to check if $galleryConfig.Icon exists before rendering. [1] [2] [3] [4]

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ettore Di Giacinto <[email protected]>
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 3122575
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/67c035af869f2a0008a2975b
😎 Deploy Preview https://deploy-preview-4913--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudler mudler merged commit 3bf2e9d into master Feb 27, 2025
22 of 24 checks passed
@mudler mudler deleted the fix/chat_ui_image branch February 27, 2025 09:52
@mudler mudler added the bug Something isn't working label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant