Lyrics Hyphen over two+ notes does not appear in Nightly

[zacjansheski]

Issue type

Engraving bug

Bug description

Lyrics Hyphen does not appear in Nightly

Steps to reproduce

1. Add notes to a score
2. Add lyrics, then hyphens over two+ notes

Screenshots/Screen recordings

MuseScore Version

OS: macOS 11.6, Arch.: x86_64, MuseScore version (64-bit): 4.2.0-232020302, revision: github-musescore-musescore-1610221

Regression

Yes, this used to work in 4.0.2 and 4.1.x

Operating system

OS: macOS 11.6

Additional context

No response

[igorkorsukov]

Behavior changed in 4.1

This one ended up being a little more in-depth than I expected it to be.
If the user places exactly one underscore (or dash) and then ends editing, the melisma is deleted and the alignment of the lyric is reset.
If the user places multiple dashes, the lyric will be left-justified (as it spans multiple notes), but if the editing ends with that string of dashes, the original lyric will again have its alignment reset and the "melisma" will be deleted.

#15459

[its-not-nice]

@igorkorsukov It does seem that this PR was responsible, but it's strange that this problem arises only in master, but not in 4.1.

To clarify: if we input a lyric containing hyphens, like this:

in 4.1, as soon as we leave editing mode, we get this, which is what we would expect:

however, in master, the hyphens then disappear as described, plus the first syllable recentres itself:

[igorkorsukov]

I will continue my research..

[mike-spa]

The problem started with #17575