Skip to content

Introducing text settings for tempo change #15822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mike-spa
Copy link
Contributor

At the moment, "Gradual tempo change" items use the style settings of the "Tempo" text, but they really should have their own, like all other items. Otherwise, it's impossible to customize the appearance of any "Gradual tempo change" item without modifying the global style settings of the "Tempo". Of course, the default settings are still the same as the "Tempo" settings. This PR just creates the dedicates settings and adds the entry to the list.

image

@mike-spa mike-spa requested a review from its-not-nice January 11, 2023 13:00
@mike-spa mike-spa force-pushed the introduceTextSettingsForTempoChange branch from 33ff84e to d151c83 Compare January 22, 2023 17:32
@its-not-nice its-not-nice added the P1 Priority: High label Feb 9, 2023
@XiaoMigros
Copy link
Contributor

Wouldn't a name like "Tempo expression" better describe this setting? I feel like "Gradual tempo change" is not encompassing enough..

@its-not-nice
Copy link
Contributor

But a 'gradual tempo change' is what they are.
Also the name has not arisen from this PR - that's what they are called already in the UI, as you can see if you select one:
image

@XiaoMigros
Copy link
Contributor

I see. But my point still stands; "a tempo" for example should, in my opinion, be stylised the same as "rit." and similar, and it is not usually a gradual change.

@DaddyLudwig
Copy link

I've seen a tempo marked both ways, in the style of a tempo marking like Allegro or Presto and in the style of a gradual change like rit. or accel. so it doesn't really matter to me.

@XiaoMigros
Copy link
Contributor

The only times I've seen 'a tempo' marked like 'Allegro', 'rit.' and similar were also marked like 'Allegro'.
It's a tiny detail that doesn't really matter, but if it was up to me I would opt for a more inclusive/comprehensive category name. Do with that what you will!

@mike-spa mike-spa force-pushed the introduceTextSettingsForTempoChange branch from d151c83 to ce54575 Compare February 23, 2023 09:44
@RomanPudashkin RomanPudashkin merged commit 126476b into musescore:master Mar 14, 2023
@mike-spa mike-spa deleted the introduceTextSettingsForTempoChange branch February 17, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants