Skip to content

Preliminary FreeBSD support. #17808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Conversation

jsm222
Copy link
Contributor

@jsm222 jsm222 commented May 31, 2023

Encountered issues so far:

open /dev/snd/seq failed:
UPDATE: can be resolved by running alsa-seq-server from audio/alsa-seq-server
The score starts zoomed in, so one has to zoom
out with the ctrl plus mouse wheel
UPDATE: Caused in my case by bad output in qt from screen()->physicalDotsPerInch(); Can be overriden with cmd line argument -D (DPI) e.g mscore -D 96

jsm222 added 2 commits June 1, 2023 01:00
 Encountered issues so far:

 open /dev/snd/seq failed:
 The score starts zoomed in, so one has to zoom
 out with the ctrl plus mouse wheel
To build
mkdir build2
cd build2
cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Debug -DMUE_BUILD_CRASHPAD_CLIENT=OFF ..
use gmake (because AFAICT a font has a space in its build target which make does not like)
@cbjeukendrup
Copy link
Member

The score starts zoomed in, so one has to zoom
out with the ctrl plus mouse wheel

That sounds similar to the problem that #17759 is solving. Might be worth trying that out!

@cbjeukendrup cbjeukendrup requested a review from igorkorsukov May 31, 2023 23:37

# include <sys/endian.h>
#x include <sys/endian.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the x symbol is superfluous here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even harmful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that was a typo. I have refactored the portable_endian.h a litte

 Remove typo
 Refacotor changes to portable_endian.h
@igorkorsukov
Copy link
Contributor

@jsm222 please update with the master to make sure the vtests fail is not related to this PR

@Jojo-Schmitz
Copy link
Contributor

Don't use merge, but something like git pull --rebase upstream master; git push -f

@jsm222
Copy link
Contributor Author

jsm222 commented Jun 2, 2023

Don't use merge, but something like git pull --rebase upstream master; git push -f

I guess we can do a squash, when/if this work is accepted.

@igorkorsukov igorkorsukov merged commit b443bf7 into musescore:master Jun 2, 2023
@jsm222
Copy link
Contributor Author

jsm222 commented Jun 2, 2023

The score starts zoomed in, so one has to zoom
out with the ctrl plus mouse wheel

That sounds similar to the problem that #17759 is solving. Might be worth trying that out!

My edid was broken and qt reported 3048 as DPI when it should be 96. The dimension of the screen were not correct in xrandr --verbose. (I have not checked qt internals) and were not 1mm x 1mm but I use a hdmi extender.. (Specifying -D 96 without your patch worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants