Skip to content

Fix GH#18166: All expression texts not exported to MusicXML #18170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Jojo-Schmitz
Copy link
Contributor

Resolves: #18166

@its-not-nice
Copy link
Contributor

This addresses standalone Expression items, but expression-type text typed directly either side of a Dynamic mark remains unexported (also a regression since 4.0). Presumbly this is also due to changes in #17001; I will be sure to have @mike-spa publicly whipped.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jun 26, 2023

Someone having a brown paperbag handy? I ran out of supplies...

Could you please open a new issue for that? I don't see a similarly simple fix for that at the moment

@its-not-nice
Copy link
Contributor

I'll get @mike-spa to clean up his own mess. Meanwhile this can be merged (we'll also need a version for the 4.1.0 branch at some point)

@Jojo-Schmitz
Copy link
Contributor Author

See #18181

@RomanPudashkin RomanPudashkin merged commit 0b14610 into musescore:master Jun 26, 2023
@Jojo-Schmitz Jojo-Schmitz deleted the musicxml-expression-text branch June 26, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Musicxml export regression] - All expression text not exported
3 participants