Fix disappearing ties when removing line break #20486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitryArefiev @zacjansheski do either of you have a moment to test this one? I don't expect there to be more issues like this, but let's keep a close eye on ties in general, especially with system breaks etc |
its-not-nice
approved these changes
Dec 14, 2023
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
RomanPudashkin
approved these changes
Dec 15, 2023
Merged
Merged
|
Check out https://musescore.org/en/comment/reply/node/357941 - ties getting drawn backwards and way too thick at the end of a score in continuous view. Not sure if it's related to this change, or to what this is fixing, or neither. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20485
This bug is just another version of #20382 (though the cause is different). The bug has always been there but was covered by other stuff that was happening which I've removed here.