Fix crash on set ornament style to always show cue note #27782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Apr 22, 2025
miiizen
approved these changes
Apr 22, 2025
|
The file was originally received in musicxml format when exporting from Dorico |
mike-spa
pushed a commit
to mike-spa/MuseScore
that referenced
this pull request
Apr 22, 2025
…tStyle Fix crash on set ornament style to always show cue note
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #27749
The crash is not file-specific. To reproduce:
What is weird in the provided file is that all the trills have a Mordent ornament inside, instead of a Trill. I have no idea how that happened because I don't know the origin of the file. Anyway, this means that the cue note won't actually show up for these trills (in fact, even their property panel shows the wrong options, e.g. "Interval below"). If necessary, this will need to be investigated separately.