fix: Lazily initialize Mesh in draw commands for webgl2 compat #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebGL appears to have a requirement that initialised buffers must have a non-zero length (or something along these lines). This changes our draw logic to lazily initialise the mesh to work around this requirement.
tychedelia
approved these changes
Mar 16, 2025
There was a problem hiding this comment.
Yes! This totally makes sense and is definitely the correct implementation with respect to this. The "mono mesh" is potentially a weird optimization but seemed to work pretty well. If we wanted in the future, it might make sense to optimize further by retaining vertex buffers, but in general these kinds of optimizations are really hard to do with the imperative drawing model as the order and number of draw commands can be totally arbitrary frame to frame. Tysm for tracking this down!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGL appears to have a requirement that initialised buffers must have a non-zero length (or something along these lines). This changes our draw logic to lazily initialise the mesh to work around this requirement.
Closes #998.
cc @tychedelia does this solution look OK?