Skip to content

Commit e5fdde8

Browse files
odrotbohmapp
authored and
app
committed
Polishing.
Ternary ifs and less nesting. Related: spring-projectsGH-3094 Original pull request: spring-projectsGH-2865
1 parent 5155112 commit e5fdde8

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

Diff for: src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,12 @@ public Pageable resolveArgument(MethodParameter methodParameter, @Nullable Model
8383
Sort sort = sortResolver.resolveArgument(methodParameter, mavContainer, webRequest, binderFactory);
8484
Pageable pageable = getPageable(methodParameter, page, pageSize);
8585

86-
if (sort.isSorted()) {
87-
if (pageable.isPaged()) {
88-
pageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
89-
}
90-
else {
91-
pageable = Pageable.unpaged(sort);
92-
}
86+
if (!sort.isSorted()) {
87+
return pageable;
9388
}
9489

95-
return pageable;
90+
return pageable.isPaged()
91+
? PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort)
92+
: Pageable.unpaged(sort);
9693
}
9794
}

Diff for: src/main/java/org/springframework/data/web/ReactivePageableHandlerMethodArgumentResolver.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,12 @@ public Pageable resolveArgumentValue(MethodParameter parameter, BindingContext b
7878
Sort sort = sortResolver.resolveArgumentValue(parameter, bindingContext, exchange);
7979
Pageable pageable = getPageable(parameter, page, pageSize);
8080

81-
if (sort.isSorted()) {
82-
if (pageable.isPaged()) {
83-
pageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
84-
}
85-
else {
86-
pageable = Pageable.unpaged(sort);
87-
}
81+
if (!sort.isSorted()) {
82+
return pageable;
8883
}
8984

90-
return pageable;
85+
return pageable.isPaged()
86+
? PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort)
87+
: Pageable.unpaged(sort);
9188
}
9289
}

0 commit comments

Comments
 (0)