Use Pageable.unpaged(sort) for sorted unpaged pageable
#2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: bug
odrotbohm
force-pushed
the
main
branch
2 times, most recently
from
fe5e80e to
98f20a4
Compare
mp911de
force-pushed
the
main
branch
2 times, most recently
from
0122d1b to
5070a0f
Compare
|
Would it be possible to handle sorted unpaged pagables as well? |
Fix java.lang.UnsupportedOperationException at org.springframework.data.domain.Unpaged.getPageNumber(Unpaged.java) at org.springframework.data.web.ReactivePageableHandlerMethodArgumentResolver.resolveArgumentValue(ReactivePageableHandlerMethodArgumentResolver.java)
quaff
changed the title
Pageable.unpaged(sort) for sorted unpaged pageable
Thanks for your suggestion, I've updated the PR. |
|
That's been polished and merged. Thanks! |
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-commons
that referenced
this pull request
May 20, 2024
The (Reactive)PageableHandlerMethodArgumentResolver now falls back to a unpaged Pageable instance with a resolved sort if the the resolved Pageable is unpaged. Fixes: spring-projectsGH-3094 Original pull request: spring-projectsGH-2865
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-commons
that referenced
this pull request
May 20, 2024
Ternary ifs and less nesting. Related: spring-projectsGH-3094 Original pull request: spring-projectsGH-2865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix