Skip to content
This repository was archived by the owner on Apr 24, 2025. It is now read-only.

feature: add dns-01 validation option #283

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Conversation

klowdo
Copy link
Contributor

@klowdo klowdo commented May 16, 2023

Hi!

Added dns-01 validation. im using this i Azure container apps to add certs with the container app env as certificate source. Very new to this so happy for all feedback.

and in order to get this working behind a reverse proxy im adding this and binding the dns with cert in other code

var lettuceKesterConfig =  builder.Services.FirstOrDefault(
                x => x.ServiceType.FullName == "LettuceEncrypt.Internal.KestrelOptionsSetup");
if (lettuceKesterConfig != null)
    builder.Services.Remove(lettuceKesterConfig);

@natemcmaster
Copy link
Owner

This looks great @klowdo ! Thanks so much for sending this PR. This has been a long-time requested feature for this project.

I'm going to merge your code, but make 2 tweaks after I do. I'm going to move all public interfaces and types out of the LettuceEncrypt.Internal.* namespace.

Really nice work though! Thanks for the contribution 👍🏻

@natemcmaster natemcmaster linked an issue Jun 25, 2023 that may be closed by this pull request
@natemcmaster natemcmaster merged commit a77e02a into natemcmaster:main Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support wildcard domains
2 participants