Skip to content

Convert leafnode solicited remotes to an array #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

Convert leafnode solicited remotes to an array #1069

merged 1 commit into from
Jul 10, 2019

Conversation

derekcollison
Copy link
Member

Resolves #1063

Signed-off-by: Derek Collison [email protected]

/cc @nats-io/core

@derekcollison derekcollison requested a review from kozlovic July 10, 2019 18:58
kozlovic
kozlovic approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the exception of removing URL from monitor object since that may break user applications.

@derekcollison derekcollison merged commit 79e6964 into master Jul 10, 2019
@derekcollison derekcollison deleted the mremotes branch July 10, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support an array of url for a single leafnode remote
2 participants
@derekcollison @kozlovic