Skip to content

[added] check for mirror stream return error when de dupe window is set #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021

Conversation

matthiashanel
Copy link
Contributor

@matthiashanel matthiashanel commented May 11, 2021

Signed-off-by: Matthias Hanel [email protected]

Noticed this in natscli, where I removed the interactive question.
For an actual check RI preferred doing this here.

ats --context=hub s add --mirror test --dupe-window=2s
? Stream Name ss
? Storage backend file
? Retention Policy Limits
? Discard Policy Old
? Stream Messages Limit -1
? Message size limit -1
? Maximum message age limit -1
? Maximum individual message size -1
? Replicas 3
? Adjust mirror start No
X Sorry, your reply was invalid: "spoke-1" is not a valid answer, please try again.
? Import mirror from a different JetStream domain Yes
? Foreign JetStream domain name spoke-1
? Delivery prefix
nats: error: could not create Stream: stream mirrors do not make use of a de-duplication window

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@matthiashanel matthiashanel merged commit 6c6c4b9 into master May 11, 2021
@matthiashanel matthiashanel deleted the mirror-dedupe branch May 11, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants