Skip to content

Should not flush in place for stream loop. #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2021
Merged

Should not flush in place for stream loop. #2337

merged 1 commit into from
Jul 1, 2021

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison [email protected]

/cc @nats-io/core

@derekcollison derekcollison requested a review from kozlovic July 1, 2021 21:22
kozlovic
kozlovic approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but may want to check the other place where we do that.

@derekcollison derekcollison requested a review from kozlovic July 1, 2021 21:30
kozlovic
kozlovic approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 73b2beb into main Jul 1, 2021
@derekcollison derekcollison deleted the flush branch July 1, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekcollison @kozlovic