Add descriptions to JetStream streams and consumers. #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but should we at the same time add them to the consumers for sources and mirrors? |
|
You mean auto-add them to any direct consumer we place on a mirror or consumer? What name should we use? |
|
Yes, when I see a mirror or source not working I also tend to see 1000s of failed API requests. Then I use nats event or just a sub to see what is going on. So in my original WIP PR I added descriptions to the consumer create requests indicating what stream is making those requests |
|
Let's sync up next week and we can do a separate PR. Want to understand a bit better. |
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison [email protected]
/cc @nats-io/core