Skip to content

[FIXED] Server not sending PINGs to TLS connections (clients or routes) #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2017
Merged

[FIXED] Server not sending PINGs to TLS connections (clients or routes) #459

merged 1 commit into from
Mar 24, 2017

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Mar 24, 2017 •
edited
Loading

  • Link to issue
  • Documentation added (N/A)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the MIT license

Resolves #458

Changes proposed in this pull request:

  • Removed unnecessary cast check to (*net.TCPConn). When the timer
    fires, the connection is already established. Replaced with check
    that connection has not been closed.
  • Add PING test that checks that pings are sent to TLS connections.
  • Changed Go version to 1.7.5 in travis.
  • Removed test package from code coverage.

/cc @nats-io/core

@kozlovic
[FIXED] Server not sending PINGs to TSL connections (clients or routes)
a0245fc 
- Removed unnecessary cast check to (*net.TCPConn). When the timer
fires, the connection is already established. Replaced with check
that connection has not been closed.
- Add PING test that checks that pings are sent to TLS connections.
- Changed Go version to 1.7.5 in travis.
- Removed test package from code coverage.
@kozlovic kozlovic requested a review from derekcollison March 24, 2017 15:51
@kozlovic kozlovic self-assigned this Mar 24, 2017
@kozlovic kozlovic changed the title [FIXED] Server not sending PINGs to TSL connections (clients or routes) [FIXED] Server not sending PINGs to TLS connections (clients or routes) Mar 24, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.889% when pulling a0245fc on fix_ping_to_tls_conn into 42a539f on master.

@derekcollison derekcollison merged commit e1abaa5 into master Mar 24, 2017
@derekcollison derekcollison deleted the fix_ping_to_tls_conn branch March 24, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison Awaiting requested review from derekcollison

Assignees

@kozlovic kozlovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ping messages are not processed on TLS connections between routes
3 participants
@kozlovic @coveralls @derekcollison