[ADDED] Systemd unit file #587
Conversation
|
Can an exclusion be added to not cover this file? |
|
@RedShift1 , thank you for the PR! I can see this having dependencies on the .rpm/.deb installations. Let's keep this open until those are created. |
|
Well here's the thing. If I add the RPM spec file before the systemd unit file, I have to reference (in the spec file) the unit file that's outside the source. So in order to successfully build the RPM, you'd need the specfile, the systemd unit file and the source tar. When the unit file is added to the source afterwards, I would have to change the spec file to reference the unit file that ships with the source tar. If we add the systemd unit file to the source before we add the spec file, then I can immediately reference the unit file from the source in the spec file. Done. |
util/gnatsd.service
Outdated
| PrivateTmp=true | ||
| Type=simple | ||
| PIDFile=/var/run/gnatsd/%i.pid | ||
| ExecStart=/usr/sbin/gnatsd -c /etc/gnatsd.conf |
There was a problem hiding this comment.
I'd recommend adding the following commands for standard reload and stop behavior:
ExecReload=/bin/kill -s HUP $MAINPID
ExecStop=/bin/kill -s QUIT $MAINPID
There was a problem hiding this comment.
Are you sure the QUIT signal is the right signal to terminate gnatsd correctly? Because gnatsd spams the logs when you send it the QUIT sig: https://pastebin.com/9D4R40b4
There was a problem hiding this comment.
SIGINT would probably be better?
There was a problem hiding this comment.
There was a problem hiding this comment.
other like TERM would not allow server to cleanly shutdown (which may be OK as a standalone process).
Removes PIDFile (gnatsd doesn't create a pid file) and implements the Reload and Stop service commands
|
lgtm |
Changes proposed in this pull request:
/cc @nats-io/core