[CHANGED] Server notifies clients when server rejoins cluster #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for accepting this change. On the c-sharp client projects, I have a PR for the client side counterpart via PR#187. --MG |
When the option Cluster.NoAdvertise is false, a server will send an INFO protocol message to its client when a server has joined the cluster. Previously, the protocol would be sent only if the joining server's "client URLs" (the addresses where clients connect to) were new. It will now be sent regardless if the server joins (for the first time) or rejoins the cluster. Clients are still by default invoking the DiscoveredServersCB callback only if they themselves detect that new URLs were added. A separate PR may be filled to client libraries repo to be able to invoke the callback anytime an async INFO protocol is received. Based on @madgrenadier PR #597.
kozlovic
force-pushed
the
always_send_info
branch
from
3fe5cd0 to
fa86ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option Cluster.NoAdvertise is false, a server will send
an INFO protocol message to its client when a server has joined
the cluster.
Previously, the protocol would be sent only if the
joining server's "client URLs" (the addresses where clients connect
to) were new. It will now be sent regardless if the server joins
(for the first time) or rejoins the cluster.
Clients are still by default invoking the DiscoveredServersCB callback
only if they themselves detect that new URLs were added. A separate
PR may be filled to client libraries repo to be able to invoke
the callback anytime an async INFO protocol is received.
Based on @madgrenadier PR #597.