TLS 1.2 Negotiation on Windows with ECDSA server certificate #6803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add script to generate it
|
Will write tests to validate this fix before marking the PR ready to merge. |
|
Coordinate with @neilalexander since we are getting close to next release and this would be good to include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6467
It appears .NET clients on Windows 10 cannot use TLS 1.3, and when negotiating down to TLS 1.2 the signature format is more strict, requiring ASN.1 DER encoding, producing a larger signature than the one generated using the more permissive TLS 1.3 signature.
This change increases the signature buffer to exactly half of the hash size.
Signed-off-by: John Weldon [email protected]