Fix panic in monitorConsumer if meta nil
#6823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
approved these changes
Apr 23, 2025
server/jetstream_cluster.go
Outdated
| @@ -4737,7 +4737,11 @@ func (js *jetStream) monitorConsumer(o *consumer, ca *consumerAssignment) { | |||
|
|
|||
| defer o.clearMonitorRunning() | |||
|
|
|||
| if n == nil { | |||
| js.mu.RLock() | |||
There was a problem hiding this comment.
func (js *jetStream) getMetaGroup() RaftNode
The equivalent in `monitorStream` already has this exact check but it never made its way into `monitorConsumer` seemingly. Buildkite runs picked up a panic here. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/ccmeta
branch
from
e595661 to
912f2c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equivalent in
monitorStreamalready has this exact check but it never made its way intomonitorConsumerseemingly. Buildkite runs picked up a panic here.Signed-off-by: Neil Twigg [email protected]