Skip to content

Cluster Protocol Rewrite #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2018
Merged

Cluster Protocol Rewrite #786

merged 5 commits into from
Nov 1, 2018

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison [email protected]

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Changes proposed in this pull request:

This is a rewrite of the cluster protocol to support accounts as well as optimize the interest graph propagation and ensure a message only goes over a route once regardless of recipients.

/cc @nats-io/core

@derekcollison
First pass at new cluster design
4796330 
Signed-off-by: Derek Collison <[email protected]>
@coveralls
Copy link

coveralls commented Oct 25, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 91.053% when pulling 5790410 on new_routes into 037acf1 on master.

@derekcollison
Fix double trace
ec3115a 
Signed-off-by: Derek Collison <[email protected]>
kozlovic
kozlovic requested changes Oct 26, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.. work in progress..

kozlovic
kozlovic reviewed Oct 26, 2018
View reviewed changes
kozlovic
kozlovic reviewed Oct 26, 2018
View reviewed changes
@derekcollison
Updates based on feedback
4058948 
Signed-off-by: Derek Collison <[email protected]>
kozlovic
kozlovic reviewed Oct 30, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intermediate review.. still more to review.

kozlovic
kozlovic reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the review

@derekcollison
Added L1 cache to routes
5790410 
Signed-off-by: Derek Collison <[email protected]>
kozlovic
kozlovic approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 57a7471 into master Nov 1, 2018
@derekcollison derekcollison deleted the new_routes branch November 1, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs left review comments

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekcollison @coveralls @wallyqs @kozlovic