Skip to content

[FIXED] Logtime reset to true on config reload #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Conversation

kozlovic
Copy link
Member

Resolves #789

Signed-off-by: Ivan Kozlovic [email protected]

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.627% when pulling d8817a3 on fix_logtime_reload into 93f7deb on master.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 2186827 into master Jan 10, 2019
@kozlovic kozlovic deleted the fix_logtime_reload branch January 10, 2019 16:31
kozlovic added a commit that referenced this pull request Jan 15, 2019
PR #874 caused an issue in case logtime was actually not configured
and not specified in the command line. A reload would then remove
logtime.

Revisited the fix for that and included other boolean flags, such
as debug, trace, etc..

Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic added a commit that referenced this pull request Jan 15, 2019
PR #874 caused an issue in case logtime was actually not configured
and not specified in the command line. A reload would then remove
logtime.

Revisited the fix for that and included other boolean flags, such
as debug, trace, etc..

Related to #874

Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic added a commit that referenced this pull request Jan 15, 2019
PR #874 caused an issue in case logtime was actually not configured
and not specified in the command line. A reload would then remove
logtime.

Revisited the fix for that and included other boolean flags, such
as debug, trace, etc..

Related to #874

Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants