Skip to content

Support relative paths in git.root #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

sghill
Copy link
Contributor

@sghill sghill commented Mar 16, 2025

Hi folks!

This adds support for relative paths in git.root in a way that seems recommended from Gradle's docs.

From a quick glance at the implementation it looks like this could be converted to use providerFactory.gradleProperty('git.root') with a convention and mapping to a file instance. I didn't take this step because it's a larger change.

Additional Context

I have a project that attempts to set git.root=.. in a nested directory. It looks like this:

rootDir
    my-gradle-project
        build.gradle
        settings.gradle
        gradle.properties
    other-project

I recently started getting a failure during Gradle's configuration phase that .. must be an absolute path, demonstrated by the included test.

@rpalcolea rpalcolea merged commit 6d8bd18 into nebula-plugins:main Mar 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants