[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #380
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/0dbeb3c7-0f2b-4df0-ac5a-fd0108caddf4?utm_source=github&utm_medium=referral&page=upgrade-pr
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a summary of this pull request. This PR, automatically generated by Snyk, aims to upgrade the @testing-library/jest-dom dependency from version 5.16.5 to 5.17.0. The primary motivation for this upgrade is to address a significant number of security vulnerabilities identified in the current version and its transitive dependencies, including several high and critical severity issues related to ReDoS, Prototype Pollution, SSRF, DoS, XSS, and more. The upgrade itself is a minor version bump and the release notes indicate the addition of a new feature (toHaveAccessibleErrorMessage) and the deprecation of an older one (toHaveErrorMessage), alongside a bug fix in a previous version (5.16.5).
Highlights
- Dependency Upgrade: Upgrades the
@testing-library/jest-dompackage from version5.16.5to5.17.0. - Security Fixes: Addresses numerous security vulnerabilities reported by Snyk, including multiple high and critical severity issues across various underlying dependencies.
- New Feature/Deprecation: The upgraded version
5.17.0introduces a new matchertoHaveAccessibleErrorMessageand deprecatestoHaveErrorMessage.
Changelog
- 0x01-react_intro/task_3/dashboard/package.json
- Updated the version of
@testing-library/jest-domin thedependenciessection from^5.16.4to^5.17.0.
- Updated the version of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A package version, old and worn,
Security flaws, a digital thorn.
Upgrade it now, make tests bright,
With jest-dom fixed, all feels right.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades @testing-library/jest-dom from ^5.16.4 (likely resolved to 5.16.5 as per Snyk's description) to ^5.17.0. This is a valuable update as it addresses numerous security vulnerabilities, including several critical and high-severity ones, as detailed in the PR description.
The change itself is a straightforward version bump in the package.json file and appears correct. Thank you for addressing these security concerns!
Summary of Findings
- Awareness of Deprecated Matcher: The release notes for
@testing-library/[email protected]mention that thetoHaveErrorMessagematcher has been deprecated in favor of a newtoHaveAccessibleErrorMessagematcher. While this upgrade is a minor version bump and shouldn't introduce breaking changes to existing usage oftoHaveErrorMessage, it would be good practice to update any instances of the deprecated matcher in your test suite to the new one when time permits. This is a low-severity item and not commented on directly due to review settings, but worth noting for future maintainability. - Lock File Update and Testing: After merging this change, remember to run
npm installoryarn installto update your lock file (package-lock.jsonoryarn.lock) and install the new version of the dependency. Thorough testing of your application, particularly the parts covered by Jest tests, is recommended to ensure this upgrade doesn't introduce any unexpected behavior. This is a general best practice for dependency upgrades and is considered low severity, hence not commented directly due to review settings.
Merge Readiness
The pull request is highly recommended for merging as it addresses significant security vulnerabilities. The code change itself is minimal and correct. Before merging, the author should ensure that their local test suite passes after updating dependencies and regenerating the lock file. As I am an AI, I am not authorized to approve pull requests; please ensure appropriate human review and approval before merging.
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 2 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-ANSIHTML-1296849
SNYK-JS-ANSIREGEX-1583908
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
SNYK-JS-IP-6240864
SNYK-JS-SSRI-1246392
SNYK-JS-UNSETVALUE-2400660
SNYK-JS-MERGE-1040469
SNYK-JS-MERGE-1042987
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-BROWSERIFYSIGN-6037026
SNYK-JS-WS-7266574
SNYK-JS-SERIALIZEJAVASCRIPT-536840
SNYK-JS-SERIALIZEJAVASCRIPT-570062
SNYK-JS-SERIALIZEJAVASCRIPT-6056521
SNYK-JS-SHELLQUOTE-1766506
SNYK-JS-LOADERUTILS-3043105
SNYK-JS-LODASHTEMPLATE-1088054
SNYK-JS-NODEFORGE-2430339
SNYK-JS-CROSSSPAWN-8303230
SNYK-JS-ELLIPTIC-8172694
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-BODYPARSER-7926860
SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
SNYK-JS-WS-7266574
SNYK-JS-IP-7148531
SNYK-JS-TERSER-2806366
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-UGLIFYJS-1727251
SNYK-JS-WEBPACK-7840298
SNYK-JS-NODEFORGE-2430341
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-POSTCSS-1255640
SNYK-JS-PROMPTS-1729737
SNYK-JS-MINIMATCH-3050818
SNYK-JS-NODEFORGE-2330875
SNYK-JS-NODEFORGE-2331908
SNYK-JS-BROWSERSLIST-1090194
SNYK-JS-COOKIE-8163060
SNYK-JS-YARGSPARSER-560381
SNYK-JS-YARGSPARSER-560381
SNYK-JS-SOCKJS-575261
SNYK-JS-ISTANBULREPORTS-2328088
SNYK-JS-JSON5-3182856
SNYK-JS-LOADERUTILS-3042992
SNYK-JS-LOADERUTILS-3105943
SNYK-JS-NODEFORGE-2430337
npm:braces:20180219
SNYK-JS-SERVESTATIC-7926865
SNYK-JS-ELLIPTIC-7577916
SNYK-JS-ELLIPTIC-7577917
SNYK-JS-ELLIPTIC-7577918
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-GLOBPARENT-1016905
SNYK-JS-HTMLMINIFIER-3091181
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-REQUEST-3361831
SNYK-JS-SEND-7926862
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-BABELTRAVERSE-5962463
SNYK-JS-WORDWRAP-3149973
Release notes
Package name: @testing-library/jest-dom
-
5.17.0 - 2023-07-18
- New
-
5.16.5 - 2022-08-04
- migrate ccs v3 to @ adobe/css-tools v4 (#470) (948d90f)
from @testing-library/jest-dom GitHub release notes5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessagebetter implementing the spec, deprecatetoHaveErrorMessage(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: