[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #391
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/22edd24b-54ca-4e0b-a30b-3a42f37de584?utm_source=github&utm_medium=referral&page=upgrade-pr
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team! Gemini here, providing a summary of this pull request. This PR, automatically generated by Snyk, aims to upgrade the @testing-library/jest-dom dependency from version 5.16.5 to 5.17.0. The primary motivation for this upgrade is to address a significant number of security vulnerabilities identified in the current version and its transitive dependencies, including several high and critical severity issues like ReDoS, Prototype Pollution, and Improper Verification of Cryptographic Signature. Additionally, the upgrade brings in a new feature: a toHaveAccessibleErrorMessage matcher, which is a better implementation of the spec and deprecates the older toHaveErrorMessage.
Highlights
- Dependency Upgrade: Upgrades the
@testing-library/jest-dompackage from version5.16.5to5.17.0. - Security Vulnerability Fixes: Addresses numerous security vulnerabilities (high, medium, and low severity) reported by Snyk in the current version and its dependencies.
- New Jest Matcher: Introduces the
toHaveAccessibleErrorMessagematcher and deprecatestoHaveErrorMessagein@testing-library/[email protected].
Changelog
- 0x01-react_intro/task_3/dashboard/package.json
- Updated the version of
@testing-library/jest-domin thedependenciessection from^5.16.4to^5.17.0(lines 6-6).
- Updated the version of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A package old and slow,
Has vulns, you know, you know.
Upgrade it fast,
Make tests hold fast,
Let secure code now flow.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This Snyk PR upgrades @testing-library/jest-dom from ^5.16.4 to ^5.17.0. This is an important update as it addresses a significant number of security vulnerabilities, including several marked as critical and high severity, as detailed in the pull request description.
The main functional change to be aware of in @testing-library/jest-dom v5.17.0, according to its release notes, is the introduction of the toHaveAccessibleErrorMessage matcher and the corresponding deprecation of the toHaveErrorMessage matcher. I've added a specific comment on this in the package.json file change.
Overall, the change is straightforward and highly beneficial from a security standpoint.
Summary of Findings
- Dependency Upgrade for Security: The PR upgrades
@testing-library/jest-dom, which is crucial for addressing numerous security vulnerabilities listed in the PR description, including critical and high severity ones. - Potential Impact: Deprecated
toHaveErrorMessagematcher: Version 5.17.0 of@testing-library/jest-domdeprecates thetoHaveErrorMessagematcher in favor oftoHaveAccessibleErrorMessage. It's advisable to check if the deprecated matcher is used in the project. If so, plan for migration to the new matcher to avoid future issues and silence potential deprecation warnings.
Merge Readiness
This pull request is an automated Snyk upgrade for @testing-library/jest-dom. Its primary purpose is to resolve a large number of security vulnerabilities, which is a significant benefit.
The upgrade itself is a minor version bump and should generally be safe. The main point of attention from a code perspective is the deprecation of the toHaveErrorMessage matcher in the new version, as noted in the review comment.
Given the substantial security improvements, this PR is highly recommended for merging. It would be beneficial to acknowledge the note about the deprecated matcher and, if it's in use, plan any necessary updates to the test suite as a follow-up or as part of this PR if deemed necessary by the team.
As an AI, I am not authorized to approve pull requests. Please ensure this change is reviewed and approved by a team member before merging.
| @@ -3,7 +3,7 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "dependencies": { | |||
| "@testing-library/jest-dom": "^5.16.4", | |||
| "@testing-library/jest-dom": "^5.17.0", | |||
There was a problem hiding this comment.
This upgrade to v5.17.0 is valuable for addressing multiple security vulnerabilities.
One notable change in this version, as per its release notes, is the introduction of a new matcher toHaveAccessibleErrorMessage and the deprecation of toHaveErrorMessage.
Could you please verify if toHaveErrorMessage is currently used in your test suite?
If it is, you might encounter deprecation warnings after this upgrade. It's recommended to migrate to the new toHaveAccessibleErrorMessage matcher when convenient to align with the library's updates, ensure future compatibility, and silence these warnings.
While the provided test files (App.test.js, Notifications.test.js) primarily use Enzyme, the project also includes @testing-library/react as a dependency, so it's possible that @testing-library/jest-dom matchers like toHaveErrorMessage are used in other test files not visible in this context.
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 2 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-ANSIHTML-1296849
SNYK-JS-ANSIREGEX-1583908
SNYK-JS-WS-7266574
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-BROWSERIFYSIGN-6037026
SNYK-JS-CROSSSPAWN-8303230
SNYK-JS-BODYPARSER-7926860
SNYK-JS-SERIALIZEJAVASCRIPT-536840
SNYK-JS-SERIALIZEJAVASCRIPT-570062
SNYK-JS-SERIALIZEJAVASCRIPT-6056521
SNYK-JS-SHELLQUOTE-1766506
SNYK-JS-SSRI-1246392
SNYK-JS-UNSETVALUE-2400660
SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
SNYK-JS-WS-7266574
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
SNYK-JS-IP-6240864
SNYK-JS-ELLIPTIC-8172694
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-LOADERUTILS-3043105
SNYK-JS-LODASHTEMPLATE-1088054
SNYK-JS-MERGE-1040469
SNYK-JS-MERGE-1042987
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-NODEFORGE-2430339
SNYK-JS-NODEFORGE-2430341
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-BROWSERSLIST-1090194
SNYK-JS-COOKIE-8163060
SNYK-JS-YARGSPARSER-560381
SNYK-JS-YARGSPARSER-560381
SNYK-JS-POSTCSS-1255640
SNYK-JS-PROMPTS-1729737
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-REQUEST-3361831
SNYK-JS-TERSER-2806366
SNYK-JS-TOUGHCOOKIE-5672873
npm:braces:20180219
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-BABELTRAVERSE-5962463
SNYK-JS-ELLIPTIC-7577916
SNYK-JS-ELLIPTIC-7577917
SNYK-JS-SOCKJS-575261
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-UGLIFYJS-1727251
SNYK-JS-WEBPACK-7840298
SNYK-JS-IP-7148531
SNYK-JS-JSON5-3182856
SNYK-JS-SEND-7926862
SNYK-JS-WORDWRAP-3149973
SNYK-JS-ELLIPTIC-7577918
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-GLOBPARENT-1016905
SNYK-JS-HTMLMINIFIER-3091181
SNYK-JS-ISTANBULREPORTS-2328088
SNYK-JS-LOADERUTILS-3042992
SNYK-JS-LOADERUTILS-3105943
SNYK-JS-MINIMATCH-3050818
SNYK-JS-NODEFORGE-2330875
SNYK-JS-NODEFORGE-2331908
SNYK-JS-NODEFORGE-2430337
SNYK-JS-SERVESTATIC-7926865
Release notes
Package name: @testing-library/jest-dom
-
5.17.0 - 2023-07-18
- New
-
5.16.5 - 2022-08-04
- migrate ccs v3 to @ adobe/css-tools v4 (#470) (948d90f)
from @testing-library/jest-dom GitHub release notes5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessagebetter implementing the spec, deprecatetoHaveErrorMessage(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: