Skip to content

Fixing wrong behaviour in GraphChart report Action #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

alfredorubin96
Copy link
Collaborator

@alfredorubin96 alfredorubin96 commented Feb 19, 2024

Drafting solution, looks like is deeper than expected in the graphChart
Still missing:

  1. can't apply rule to links
  2. to understand why the code is breaking from the graphChart (ruleValues arrive in the form (label.rValue)

@alfredorubin96 alfredorubin96 changed the title drafting solution, looks like is deeper than expected in the graphChart Fixing wrong behaviour in GraphChart report Action Feb 19, 2024
@alfredorubin96 alfredorubin96 linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (20e4e0a) 39.07% compared to head (48c0adc) 38.81%.
Report is 89 commits behind head on develop.

❗ Current head 48c0adc differs from pull request most recent head d56cccd. Consider uploading reports for the commit d56cccd to get more accurate results

Files Patch % Lines
...rc/extensions/actions/ActionsRuleCreationModal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #782      +/-   ##
===========================================
- Coverage    39.07%   38.81%   -0.27%     
===========================================
  Files          208      211       +3     
  Lines         8721     8837     +116     
  Branches      2598     2637      +39     
===========================================
+ Hits          3408     3430      +22     
- Misses        5252     5346      +94     
  Partials        61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nielsdejong nielsdejong self-assigned this Feb 21, 2024
@nielsdejong
Copy link
Collaborator

Lets create a seperate issue for the other tasks, it definitely is much bigger!
Will merge this for 2.4.3

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nielsdejong nielsdejong merged commit 8dabb29 into develop Feb 22, 2024
@alfredorubin96 alfredorubin96 deleted the fix/graph-report-action branch February 28, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphChart report action - Not Working
2 participants