Makes the semantic analysis work with partial queries #519
Conversation
🦋 Changeset detectedLatest commit: 7fcb568 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -337,7 +337,7 @@ describe('Semantic validation spec', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| test('Does not trigger semantic errors when there are syntactic errors', () => { | |||
| test('Does not trigger semantic errors when there are irrecoverable syntactic errors', () => { | |||
There was a problem hiding this comment.
What is the difference between an "irrecoverable" syntactic error and a "recoverable" one?
Im thinking something like "The semantic analysis is always run now, but when parsing the query breaks so early that antlr doesnt see the later clauses for what they are, there's nothing to analyze"?
In this case - parsing breaks on metch, and we never parse n and m as variables
There was a problem hiding this comment.
As I explained in a call: irrecoverable syntactic errors are those that would not produce any AST whatsoever
What
Makes it possible to run the transpiled semantic analysis on unfinished queries:
Before we were getting only syntax errors on queries like:
Now:
How
It updates the semantic analysis artifacts that have already been modified to run the semantic analysis even if the AST would generate a null.