Fix missing inclusion of neo4j_schema in custom prompt generation #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the
Text2CypherRetriever
initialization method so that the instance can holdneo4j_schema
whencustom_prompt
is provided.I assume some users might want to make a custom prompt based on
DEFAULT_TEMPLATE
, leaving parameters in it. When initializing the class withneo4j_schema
,examples
, andcustom_prompt
like above then searchingquery_text
withoutprompt_params
,examples
is embedded in the prompt, butneo4j_schema
is not. So I fixed this behavior so that both parameters are embedded in the prompt, which is more consistent.Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):