Skip to content

[Feature Request] RxJS as a peer dependency #978

Open
@rraziel

Description

@rraziel

Driver version: JS driver 4.4.7

RxJS 7 has been released a while back, and projects that use this version have observables that are not quite compatible with the ones from RxJS 6, mostly due to changes in their internals, e.g.:

Type 'Observable<T>' is missing the following properties from type 'Observable<T>': _isScalar, _trySubscribe, _subscribe

While bumping the neo4j-javascript-driver dependency to RxJS 7.x would solve this, it would likely bring similar issues for projects still using RxJS 6.x.

An alternative would be to have RxJS as a peer dependency (as projects that use the reactive sessions likely already use RxJS in other parts of the codebase) and broaden the version requirements so version 6 and 7 may be used.

Expected behavior

The RxJS package/module is a peer dependency.

Actual behavior

The RxJS package/module is a normal dependency

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions