Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conditional rendering for the image element (and support for future renderers). The image element is now only rendered if it was passed to the
QRious
constructor as theelement
option OR if theQRious#image
field is referenced at any time (even if it's not used, we can't tell the difference). Thecanvas
element is still always rendered asimage
depends on it.Not only will this help with possible Content Security Policy (CSP) issues (see #71) but I should think that it will also improve performance for those only using
canvas
elements as the browser will no longer spend time generating a data URI for theimage
element.To summarise, the
image
element will only be rendered in the following situations: