Single Run DDP Example Script #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en and project name
…calculate gradient norms for batch (step) rather than epoch
…debugging when building LLM's
…sses using the data loader
…multi GPU's are available
…ng options for running different scenarios
… for testing scripts
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- how-to-guides/ddp-training/scripts/requirements.txt: Language not supported
- how-to-guides/ddp-training/scripts/run_examples.sh: Language not supported
Comments suppressed due to low confidence (2)
how-to-guides/ddp-training/scripts/train_ddp_single_run.py:18
- The function name 'create_dataloader_minst' appears to have a typo. Consider renaming it to 'create_dataloader_mnist' for consistency with the MNIST dataset.
def create_dataloader_minst(
how-to-guides/ddp-training/scripts/train_ddp_single_run.py:244
- The tag 'Torch-MINST' seems to be a typo. Consider updating it to 'Torch-MNIST' to correctly reference the MNIST dataset.
run.add_tags(tags=["Torch-MINST", "ddp", "single-node", params["optimizer"]])
Comment on lines
+42
to
+43
| | DDP training scripts | [![docs]]() | | [![github]](how-to-guides/ddp-training/scripts/) | | | ||
|
|
There was a problem hiding this comment.
The docs link for 'DDP training scripts' is empty. Please provide a valid URL or remove the placeholder link to prevent confusion.
Suggested change
| | DDP training scripts | [![docs]]() | | [![github]](how-to-guides/ddp-training/scripts/) | | | |
| | DDP training scripts | | | [![github]](how-to-guides/ddp-training/scripts/) | | |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@LeoRoccoBreedt - can you make the suggested changes, including the ones hidden? They are valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: <ClickUp/JIRA task name>
Any expected test failures?
Add a
[X]to relevant checklist items❔ This change
✔️ Pre-merge checklist
🧪 Test Configuration