Skip to content

Leave pipewire group along with audio group if logind is absent #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amano-kenji opened this issue Sep 6, 2023 · 2 comments · Fixed by #5993
Closed

Leave pipewire group along with audio group if logind is absent #5992

amano-kenji opened this issue Sep 6, 2023 · 2 comments · Fixed by #5993

Comments

@amano-kenji
Copy link
Contributor

amano-kenji commented Sep 6, 2023 •
edited
Loading

Description

Currently, if noroot and nogroups are present without nosound and logind is absent, audio group remains, but pipewire groups doesn't remain. pipewire group is important for giving realtime priority to pipewire clients.
@kmk3
Copy link
Collaborator

kmk3 commented Sep 6, 2023

Currently, if noroot and nogroups are present without nosound and
logind is absent, sound group remains, but pipewire groups doesn't
remain. pipewire group is important for giving realtime priority to
pipewire clients.

What distribution and firejail version?

Do you mean the audio group or is there an actual sound group?

I don't think there is anything done for the latter in the code.

@amano-kenji amano-kenji changed the title Leave pipewire group along with sound group if logind is absent. Leave pipewire group along with audio group if logind is absent. Sep 7, 2023
@amano-kenji
Copy link
Contributor Author

amano-kenji commented Sep 7, 2023 •
edited
Loading

I fixed the typos.

Distribution: Gentoo Linux
firejail version:

firejail version 0.9.72

Compile time support:
        - always force nonewprivs support is disabled
        - AppArmor support is enabled
        - AppImage support is enabled
        - chroot support is enabled
        - D-BUS proxy support is enabled
        - file transfer support is enabled
        - firetunnel support is disabled
        - IDS support is disabled
        - networking support is enabled
        - output logging is enabled
        - overlayfs support is disabled
        - private-home support is enabled
        - private-cache and tmpfs as user enabled
        - SELinux support is disabled
        - user namespace support is enabled
        - X11 sandboxing support is enabled

kmk3 added a commit to kmk3/firejail that referenced this issue Sep 7, 2023
@kmk3
modif: keep pipewire group unless nosound is used
a1597e8 
This group is apparently used on Gentoo[1].

Currently only the "audio" supplementary group is kept.

Fixes netblue30#5992.

See also commit f329386 ("Keep vglusers group unless no3d is used
(virtualgl)", 2022-01-07) / PR netblue30#4851.

[1] https://wiki.gentoo.org/wiki/PipeWire

Reported-by: @amano-kenji
@kmk3 kmk3 mentioned this issue Sep 7, 2023
Merged
kmk3 added a commit to kmk3/firejail that referenced this issue Sep 20, 2023
@kmk3
modif: keep pipewire group unless nosound is used
08a8c01 
This group is apparently used on Gentoo[1].

Currently only the "audio" supplementary group is kept.

Fixes netblue30#5992.

See also commit f329386 ("Keep vglusers group unless no3d is used
(virtualgl)", 2022-01-07) / PR netblue30#4851.

[1] https://wiki.gentoo.org/wiki/PipeWire

Reported-by: @amano-kenji
kmk3 added a commit to kmk3/firejail that referenced this issue Sep 20, 2023
@kmk3
modif: keep pipewire group unless nosound is used
0091caf 
This group is apparently used on Gentoo[1].

Currently only the "audio" supplementary group is kept.

Fixes netblue30#5992.

See also commit f329386 ("Keep vglusers group unless no3d is used
(virtualgl)", 2022-01-07) / PR netblue30#4851.

[1] https://wiki.gentoo.org/wiki/PipeWire

Reported-by: @amano-kenji
@kmk3 kmk3 mentioned this issue Dec 14, 2023
Open
7 tasks
@github-project-automation github-project-automation bot moved this to Done (on RELNOTES) in Release 0.9.74 Aug 28, 2024
@kmk3 kmk3 changed the title Leave pipewire group along with audio group if logind is absent. Leave pipewire group along with audio group if logind is absent Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Release 0.9.74
Status: Done (on RELNOTES)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modif: keep pipewire group unless nosound is used kmk3/firejail
2 participants
@kmk3 @amano-kenji